Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tooltip to make people aware of API JSON format #129

Merged
merged 2 commits into from Oct 26, 2018

Conversation

@patschi
Copy link
Member

@patschi patschi commented Sep 5, 2018

This is a simple idea to make people aware about the JSON-possibility, if someone requires that. I would have used <strong> and <em> to make the tooltip just a little bit nicier, but that doesn't work out that quite well as HTML is not allowed within that tooltips - probably because of good reasons (e,g, XSS)

Looks like:
image

Way of formating mentioned in nextcloud/server#7474

patschi added 2 commits Sep 4, 2018
Signed-off-by: Patrik Kernstock <info@pkern.at>
Signed-off-by: Patrik Kernstock <info@pkern.at>
@patschi patschi requested a review from nickvergessen Sep 5, 2018
@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 5, 2018

We could also add a button next to the input which makes it toggle between json and xml

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Change makes sense 👍

@MorrisJobke MorrisJobke merged commit 4d7d606 into master Oct 26, 2018
4 checks passed
4 checks passed
Scrutinizer No new issues
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MorrisJobke MorrisJobke deleted the feature/noid/api-info-json-format branch Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants