New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socialsharing_email 1.0.5 kills public sharing by link #29

Closed
herrmannsdorfer opened this Issue Jan 8, 2019 · 12 comments

Comments

Projects
None yet
10 participants
@herrmannsdorfer
Copy link

herrmannsdorfer commented Jan 8, 2019

Roeland,

your fix #27 killed the "Share link" option for creating a public link. Disabling your app restores the function.

share_link

@rullzer

This comment has been minimized.

Copy link
Member

rullzer commented Jan 8, 2019

mmm @skjnldsv @juliushaertl seems the share new share link broke this integration

@kchan101

This comment has been minimized.

Copy link

kchan101 commented Jan 12, 2019

It also stops any existing shares from being listed so that they can't be deleted/updated etc

@violoncelloCH

This comment has been minimized.

Copy link
Member

violoncelloCH commented Jan 13, 2019

this is the according error in the browser console:
ReferenceError: link is not defined sharedialoglinkshareview.js:585:5

render/<
https://ncdev/core/js/sharedialoglinkshareview.js:585:5
m.forEach
https://ncdev/core/vendor/underscore/underscore-min.js:5:2350
addMethod/<
https://ncdev/core/vendor/backbone/backbone.js:87:25
render
https://ncdev/core/js/sharedialoglinkshareview.js:583:4
render
https://ncdev/core/js/sharedialogview.js:785:4
initialize/<
https://ncdev/core/js/sharedialogview.js:82:5
triggerEvents
https://ncdev/core/vendor/backbone/backbone.js:371:32
triggerApi
https://ncdev/core/vendor/backbone/backbone.js:356:19
eventsApi
https://ncdev/core/vendor/backbone/backbone.js:155:16
Events.trigger
https://ncdev/core/vendor/backbone/backbone.js:346:5
set
https://ncdev/core/vendor/backbone/backbone.js:515:11
fetch/<
https://ncdev/core/js/shareitemmodel.js:739:5
j
https://ncdev/core/vendor/jquery/dist/jquery.min.js:2:26920
fireWith
https://ncdev/core/vendor/jquery/dist/jquery.min.js:2:27738
h/<
https://ncdev/core/vendor/jquery/dist/jquery.min.js:2:29050
j
https://ncdev/core/vendor/jquery/dist/jquery.min.js:2:26920
fireWith
https://ncdev/core/vendor/jquery/dist/jquery.min.js:2:27738
x
https://ncdev/core/vendor/jquery/dist/jquery.min.js:4:11251
b/<
https://ncdev/core/vendor/jquery/dist/jquery.min.js:4:14765

@violoncelloCH violoncelloCH added the bug label Jan 13, 2019

@e-alfred

This comment has been minimized.

Copy link

e-alfred commented Jan 15, 2019

Can confirm, disabling the Social Sharing app fixes the missing "Share link" button.

@LsPjvVzszDt

This comment has been minimized.

Copy link

LsPjvVzszDt commented Jan 17, 2019

Disabling the Social Sharing app fixes the missing "Share link" button for my server (having upgraded from 14 to 15.0.2).

But I can only create a new share in Chromium.
In Firefox there is no + displayed to the right of the share link text.

@Huster-at-github

This comment has been minimized.

Copy link

Huster-at-github commented Jan 19, 2019

But I can only create a new share in Chromium.
In Firefox there is no + displayed to the right of the share link text.

Same here:

Firefox
grafik

Chrome
grafik

@LsPjvVzszDt

This comment has been minimized.

Copy link

LsPjvVzszDt commented Jan 19, 2019

I found that I could also have Chrome not display the share icon.

For both browsers disabling the ad-blocker resolved the issue.

@Huster-at-github

This comment has been minimized.

Copy link

Huster-at-github commented Jan 20, 2019

Yes: Disabling UBO worked ..... strange because it told me that nothing was blocked:

grafik

@simonspa

This comment has been minimized.

Copy link

simonspa commented Jan 20, 2019

For me, it not only removed the "share link" but also the list of already active shares. Deactivating the adblocker made no difference, but deactivating this app shows everything as it should.

@supremesyntax

This comment has been minimized.

Copy link

supremesyntax commented Jan 22, 2019

Disabling "Social sharing via Diaspora" did the trick for me

@simonspa

This comment has been minimized.

Copy link

simonspa commented Jan 22, 2019

The social sharing app seems to cause the content of linkShareView and shareeListView to not be loaded - the divs are there:

Social sharing diabled:

image

Social sharing enabled:

image

@juliushaertl

This comment has been minimized.

Copy link
Member

juliushaertl commented Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment