[stable16] Fix screensharing offer sent to peers not in the call #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Despite its name, "usersInCallMapping" includes all the users in the room, not only those currently in the call. Therefore, when iterating through it, it should be checked whether a user is in the call or not to prevent sending the screensharing offer to peers not in the call. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
backportbot-nextcloud
bot
added
bug
feature: frontend 🖌️
backportbot-nextcloud
bot
requested review from
danxuliu,
fancycode,
Ivansss and
nickvergessen
2 tasks
Ivansss
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1745