Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get room properties for the signaling server from separate function. #2260

Open
wants to merge 1 commit into
base: master
from

Conversation

@fancycode
Copy link
Member

commented Oct 2, 2019

This makes it easier to extend the properties in the future (@danxuliu might need this for #2146).

Also dispatch an event so other apps can extend the properties to return.

Also dispatch an event so other apps can extend the properties to return.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
@nickvergessen

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

But this is not related to the idea we had at the conference, that external signaling should not be used for one-to-one conversations, right?

@fancycode

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

This is unrelated to the p2p for one-to-one conversations. #2146 is about no event being sent to guest users if the lobby flag is changed. This was because the properties didn't change and thus the signaling server didn't send out an event.

@danxuliu and I talked about adding a new property in the signaling properties for the lobby flag which will then change and trigger the event to all users. With this change, there is a central location where the room properties for the signaling server are defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.