Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the avatar of deleted users #2460

Merged
merged 1 commit into from Nov 14, 2019
Merged

Fix the avatar of deleted users #2460

merged 1 commit into from Nov 14, 2019

Conversation

nickvergessen
Copy link
Member

  1. As user1 create a conversation with user2
  2. As user2 write something in the chat
  3. Delete user2
  4. As user1 check the chat

Before

>_ Bot avatar

After

X Guest style avatar

@nickvergessen
Fix the avatar of deleted users
6198aa7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the 💚 Next Major (18) milestone Nov 13, 2019
marcoambrosini
marcoambrosini approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, but should we use the icon-close icon instead of the X character?

@nickvergessen nickvergessen merged commit d81a6d8 into master Nov 14, 2019
@nickvergessen nickvergessen deleted the bugfix/noid/avatar-of-deleted-users branch November 14, 2019 20:08
@nickvergessen
Copy link
Member Author

Oh, now I read your comment. Hmm could also do that. not sure how the 2 backgrounds will work out, but feel free to give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickvergessen @marcoambrosini