Get rid of "hark" data channel #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Web UI sends "speaking" and "stoppedSpeaking" messages through the "status" and "hark" data channels, but the messages are simply ignored when received in the "hark" data channel. The Android and iOS apps do not even use the "hark" data channel, neither for sending nor for listening, so it can be fully removed. Moreover, with latest Janus versions the peers receive all data channel messages in the "JanusDataChannel" data channel, no matter on which data channel they were originally sent. As the "speaking" and "stoppedSpeaking" messages are sent through the "status" data channel sending them too through the "hark" data channel caused the messages to be handled twice. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
feature: WebRTC 🚡
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Web UI sends
speakingandstoppedSpeakingmessages through thestatusandharkdata channels, but the messages are simply ignored when received in theharkdata channel. The Android and iOS apps do not even use theharkdata channel, neither for sending nor for listening, so it can be fully removed.Moreover, with latest Janus versions the peers receive all data channel messages in the
JanusDataChanneldata channel, no matter on which data channel they were originally sent. As thespeakingandstoppedSpeakingmessages are sent through thestatusdata channel sending them too through theharkdata channel caused the messages to be handled twice.