Comments manager uses the PSR logger now #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
Oct 7, 2020
•
nickvergessen
commented
- Requires Use PSR logger interface in comments manager server#23244
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/comments-manager-uses-psr-logger
branch
from
69e34d6
to
51773d0
Compare
jancborchardt
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
Fixes this issue when upgrading to 21 master for me:
Message: Argument 2 passed to OC\Comments\Manager::__construct() must implement interface Psr\Log\LoggerInterface, instance of OC\AppFramework\Logger given, called in /home/jan/nextcloud/apps/spreed/lib/Chat/CommentsManager.php on line 46
File: /home/jan/nextcloud/lib/private/Comments/Manager.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.