New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split "being in a room" from "calling" #459

Merged
merged 4 commits into from Nov 3, 2017

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Oct 31, 2017

  • Add new endpoints
  • Split JS on the UI

Fix #431

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Oct 31, 2017

Member

I'm a bit lost atm.
Should we start "Signaling" when joining a room, or only when joining a call?

Member

nickvergessen commented Oct 31, 2017

I'm a bit lost atm.
Should we start "Signaling" when joining a room, or only when joining a call?

@fancycode

This comment has been minimized.

Show comment
Hide comment
@fancycode

fancycode Nov 2, 2017

Member

Should we start "Signaling" when joining a room, or only when joining a call?

I think it makes sense to establish the signaling connection once a user joins a room. That way all in-room notifications to the user (e.g. call started) could also be triggered through the standalone signaling server to avoid the polling overhead.

Member

fancycode commented Nov 2, 2017

Should we start "Signaling" when joining a room, or only when joining a call?

I think it makes sense to establish the signaling connection once a user joins a room. That way all in-room notifications to the user (e.g. call started) could also be triggered through the standalone signaling server to avoid the polling overhead.

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Nov 2, 2017

Member

Should be good to go for version 1.0 now @Ivansss

Member

nickvergessen commented Nov 2, 2017

Should be good to go for version 1.0 now @Ivansss

nickvergessen and others added some commits Oct 26, 2017

Split joining a room and joining a call API wise
Signed-off-by: Joas Schilling <coding@schilljs.com>
Fix the UI to correctly join the room and the call
Signed-off-by: Joas Schilling <coding@schilljs.com>
Added missing leave call function.
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Rearrange steps in startSpreed function (fix problems joining a room …
…from a url with room token).

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss

Ivansss approved these changes Nov 3, 2017

@Ivansss Ivansss merged commit 4c21ab3 into master Nov 3, 2017

1 check failed

continuous-integration/drone/pr the build failed
Details

@Ivansss Ivansss deleted the joining branch Nov 3, 2017

@nickvergessen nickvergessen referenced this pull request Nov 16, 2017

Merged

Fix call activity #480

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment