New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of "[audio|video][On|Off]" datachannel messages. #466

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@fancycode
Member

fancycode commented Nov 9, 2017

Instead of sending something through the datachannels to all peers, a client locally detects if a remote peer is sending audio and/or video and updates the local UI accordingly.

This fixes / implements my suggestion from #397.

Get rid of "[audio|video][On|Off]" datachannel messages.
Instead of sending something through the datachannels to all peers,
a client locally detects if a remote peer is sending audio and/or
video and updates the local UI accordingly.

Signed-off-by: Joachim Bauch <bauch@struktur.de>

@fancycode fancycode requested a review from Ivansss Nov 9, 2017

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Nov 14, 2017

Member

For me this works only initial. But when I (un)mute my mic later on, the famous mic icon is not displayed above the username anymore.

Member

nickvergessen commented Nov 14, 2017

For me this works only initial. But when I (un)mute my mic later on, the famous mic icon is not displayed above the username anymore.

@nickvergessen nickvergessen added this to the 3.0.1 (Nextcloud 13.0.1/2) milestone Nov 14, 2017

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Jan 8, 2018

Member

Moving to 3.1 because of timing reasons

Member

nickvergessen commented Jan 8, 2018

Moving to 3.1 because of timing reasons

@nickvergessen nickvergessen modified the milestones: 3.0 (Nextcloud 13.0.0), 3.1 (Nextcloud 13.0.2/3) Jan 8, 2018

@nickvergessen nickvergessen changed the base branch from master to stable13 Jan 15, 2018

@nickvergessen nickvergessen changed the base branch from stable13 to master Mar 9, 2018

@nickvergessen nickvergessen modified the milestones: 3.2 (Nextcloud 13.0.2), 4.0 (Nextcloud 14) Mar 9, 2018

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Mar 9, 2018

Member

@Ivansss whats the status here?

Member

nickvergessen commented Mar 9, 2018

@Ivansss whats the status here?

@Ivansss

This comment has been minimized.

Show comment
Hide comment
@Ivansss

Ivansss Mar 9, 2018

Member

Not consistent. Sometimes audio mute is detected (and the mute indicator is shown) some others not.

Member

Ivansss commented Mar 9, 2018

Not consistent. Sometimes audio mute is detected (and the mute indicator is shown) some others not.

@nickvergessen nickvergessen modified the milestones: Next Major, backlog Jul 27, 2018

@fancycode

This comment has been minimized.

Show comment
Hide comment
@fancycode

fancycode Jul 30, 2018

Member

With #911 we will have a single location containing the participant state and information if audio and/or video is published. We then wouldn't need the "[audio|video][On|Off]" events any longer.

Member

fancycode commented Jul 30, 2018

With #911 we will have a single location containing the participant state and information if audio and/or video is published. We then wouldn't need the "[audio|video][On|Off]" events any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment