Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce sent information with disabled videos #7673

Merged
merged 4 commits into from Aug 11, 2022

Conversation

danxuliu
Copy link
Member

@danxuliu danxuliu commented Aug 4, 2022

The stream sent to other peers is now separate from the one locally shown. This makes possible to adjust them independently to work around specific browser behaviours, for example, to ensure that zero-information-content video tracks will be always received by other participants when needed.

@danxuliu danxuliu added 3. to review bug feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Aug 4, 2022
@danxuliu danxuliu added this to the 💚 Next Major (25) milestone Aug 4, 2022
@danxuliu
Copy link
Member Author

danxuliu commented Aug 4, 2022

/backport to stable24

@danxuliu
Copy link
Member Author

danxuliu commented Aug 4, 2022

/backport to stable23

Until now the stream locally shown was the stream sent to the other
peers. Now there are separate streams for each case to be able to adjust
them independently to work around specific browser behaviours.

Nevertheless, the sent stream is a single stream shared by all sender
peers, not a stream specific for each peer, so it is still generated in
the local media class, just like the local stream.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This ensures that other participants will receive a black video track
when no visible video should be sent, even if the browser does not
properly update a previously sent track when disabled or stopped.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Although the previous behaviour should be fine this aligns the behaviour
of removed tracks with disabled and stopped tracks.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Sometimes Chromium does not render one or more frames to the stream
captured from a canvas, so the canvas is now rendered several times and
for a longer period to try to avoid that issue.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu force-pushed the enforce-zero-information-content-video-tracks branch from f00c1b2 to 1e1c4bc Compare August 11, 2022 08:37
@nickvergessen nickvergessen changed the title Enforce zero information content video tracks Reduce sent information with disabled videos Aug 11, 2022
@nickvergessen nickvergessen merged commit e40448a into master Aug 11, 2022
13 of 14 checks passed
@nickvergessen nickvergessen deleted the enforce-zero-information-content-video-tracks branch August 11, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants