New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unread message count to the room list #806

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Apr 23, 2018

Part 1 of #798

@nickvergessen nickvergessen added this to the 4.0 (Nextcloud 14) milestone Apr 23, 2018

@nickvergessen nickvergessen requested review from Ivansss and danxuliu Apr 23, 2018

@danxuliu

I think that in this case the counter should be more prominent than the default counter used in other apps so it is easier for the user to see that there are unread messages.

Current:
unread-message-count-current

Proposed (ignore the change in position, it was a quick hack :-) ):
unread-message-count-proposed

I would also make even more prominent when there is an unread mention (but that would be something for another pull request):
unread-message-count-proposed-future

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Apr 24, 2018

Member

Not our story, the navigation HTML+CSS is managed in the server repo, I'm just copying it to here. We will not change it to be different

Member

nickvergessen commented Apr 24, 2018

Not our story, the navigation HTML+CSS is managed in the server repo, I'm just copying it to here. We will not change it to be different

@danxuliu

This comment has been minimized.

Show comment
Hide comment
@danxuliu

danxuliu Apr 24, 2018

Member

Yes, I know that the counter style comes from the server. But although consistency with the server is fine, if something does not fit with the needs of an app it should be changed in the app. And the counter of how many unread messages are in a conversation is not the same as, for example, the number of contacts in a group in the Contacts app, and it does not require the same degree of attention from the user either.

Member

danxuliu commented Apr 24, 2018

Yes, I know that the counter style comes from the server. But although consistency with the server is fine, if something does not fit with the needs of an app it should be changed in the app. And the counter of how many unread messages are in a conversation is not the same as, for example, the number of contacts in a group in the Contacts app, and it does not require the same degree of attention from the user either.

Add unread message count to the room list
Signed-off-by: Joas Schilling <coding@schilljs.com>

@Ivansss Ivansss merged commit 16bc888 into master Apr 24, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@Ivansss Ivansss deleted the feature/noid/unread-message-count branch Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment