New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mentions more prominent #813

Merged
merged 1 commit into from Apr 26, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Apr 25, 2018

Fixes #811

Before:
chat-mention-original

After:
chat-mention-highlight-all

Make mentions more prominent
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Apr 25, 2018

Member

Looks good, should we ask more designers? Or just do it and patch comments to look like this?

Member

nickvergessen commented Apr 25, 2018

Looks good, should we ask more designers? Or just do it and patch comments to look like this?

@danxuliu

This comment has been minimized.

Show comment
Hide comment
@danxuliu

danxuliu Apr 25, 2018

Member

should we ask more designers?

I just made the pull request to be able to backport and include it in 3.2 if needed, so as you wish ;-)

patch comments to look like this?

Indeed, that was the next step ;-)

Member

danxuliu commented Apr 25, 2018

should we ask more designers?

I just made the pull request to be able to backport and include it in 3.2 if needed, so as you wish ;-)

patch comments to look like this?

Indeed, that was the next step ;-)

@Ivansss Ivansss merged commit 1968038 into master Apr 26, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@Ivansss Ivansss deleted the make-mentions-more-prominent branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment