Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Сorrect hover styles for buttons in TopBar during a call #8671

Merged

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 2, 2023

Manual backport of #8661 to stable25

Somehow, :deep(.selector) isn't working in previous version, so it was changed to ::v-deep .selector
Please also check it visually on running stable25 version

🚧 TODO

  • Code-review
  • Visual check

🏁 Checklist

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@ShGKme
Copy link
Contributor

ShGKme commented Feb 2, 2023

Somehow, :deep(.selector) isn't working in previous version, so it was changed to ::v-deep .selector

stable25 already uses Vue 2.7. But this feature also requires a vue-loader minor update (16.9 -> 16.10).

The required minor update was already applied in @nextcloud/webpack-vue-config: https://github.com/nextcloud/webpack-vue-config/releases/tag/v5.4.0

We may apply the latest minor update 5.3.0 -> 5.4.0 of @nextcloud/webpack-vue-config on stable25. Then :deep must work fine.

@nickvergessen
Copy link
Member

I prefer ::v-deep() over bumping dependencies on stable branches

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also check it visually on running stable25 version

fix

@nickvergessen nickvergessen merged commit b1a1e39 into stable25 Feb 2, 2023
@nickvergessen nickvergessen deleted the fix/8019/stable25-correct-buttons-hover-in-call branch February 2, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants