Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(performance): Update conversation data for chat messages and cal… #8723

Merged
merged 1 commit into from
Feb 8, 2023
Merged

feat(performance): Update conversation data for chat messages and cal… #8723

merged 1 commit into from
Feb 8, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 8, 2023 •
edited
Loading

…ls from the notification

Ref #8710

🏁 Checklist

@nickvergessen nickvergessen added this to the 💚 Next Major (26) milestone Feb 8, 2023
@nickvergessen nickvergessen self-assigned this Feb 8, 2023
@nickvergessen nickvergessen mentioned this pull request Feb 8, 2023
Closed
16 tasks
juliushaertl
juliushaertl approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I've seen it working

@nickvergessen nickvergessen force-pushed the perf/8710/update-conversation-list-from-notification-data branch from 2fa2826 to 982b378 Compare February 8, 2023 19:04
Antreesy
Antreesy reviewed Feb 8, 2023
View reviewed changes
src/store/conversationsStore.js Outdated Show resolved Hide resolved
src/store/conversationsStore.js Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the perf/8710/update-conversation-list-from-notification-data branch from 982b378 to 526a976 Compare February 8, 2023 19:20
@nickvergessen
feat(performance): Update conversation data for chat messages and cal…
dcebb08 
…ls from the notification

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the perf/8710/update-conversation-list-from-notification-data branch from 526a976 to dcebb08 Compare February 8, 2023 19:51
@nickvergessen nickvergessen merged commit b7c98ae into master Feb 8, 2023
@nickvergessen nickvergessen deleted the perf/8710/update-conversation-list-from-notification-data branch February 8, 2023 20:16
@nickvergessen nickvergessen mentioned this pull request Feb 21, 2023
Merged
1 task
@nickvergessen nickvergessen mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@juliushaertl juliushaertl juliushaertl approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@nickvergessen nickvergessen

Labels
3. to review enhancement feature: call 📹 Voice and video calls feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client performance 🚀
Projects
None yet
Milestone
v16.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @juliushaertl @Antreesy