From 91c8db91f819e3a7c19121369fe5e148e61cca5a Mon Sep 17 00:00:00 2001 From: Cleopatra Enjeck M Date: Fri, 5 Apr 2024 12:31:50 +0100 Subject: [PATCH] fix: do not use negative indices Signed-off-by: Cleopatra Enjeck M --- lib/Service/TableTemplateService.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Service/TableTemplateService.php b/lib/Service/TableTemplateService.php index d26d2eb37..4ccd945b1 100644 --- a/lib/Service/TableTemplateService.php +++ b/lib/Service/TableTemplateService.php @@ -469,8 +469,8 @@ private function makeVacationRequests(Table $table):void { 'title' => $this->l->t('Create Vacation Request'), 'emoji' => '️➕', 'columns' => json_encode([$columns['employee']->getId(), $columns['from']->getId(), $columns['to']->getId(), $columns['workingDays']->getId(), $columns['dateRequest']->getId()]), - 'sort' => json_encode([["columnId" => -5, "mode" => "ASC"]]), - 'filter' => json_encode([[["columnId" => -2, "operator" => "is-equal", "value" => "@my-name"], ["columnId" => $columns['approved']->getId(), "operator" => "is-empty", "value" => ""]]]), + 'sort' => json_encode([["columnId" => $columns['from']->getId(), "mode" => "ASC"]]), + 'filter' => json_encode([[["columnId" => $columns['employee']->getId(), "operator" => "is-equal", "value" => "@my-name"], ["columnId" => $columns['approved']->getId(), "operator" => "is-empty", "value" => ""]]]), ] ); $this->createView($table, @@ -491,8 +491,8 @@ private function makeVacationRequests(Table $table):void { 'columns' => json_encode(array_values(array_map(function ($col) { return $col->getId(); }, $columns))), - 'sort' => json_encode([["columnId" => -3, "mode" => "ASC"]]), - 'filter' => json_encode([[["columnId" => -2, "operator" => "is-equal", "value" => "@my-name"]]]), + 'sort' => json_encode([["columnId" => $columns['dateRequest']->getId(), "mode" => "ASC"]]), + 'filter' => json_encode([[["columnId" => $columns['employee']->getId(), "operator" => "is-equal", "value" => "@my-name"]]]), ] ); $this->createView($table, @@ -502,7 +502,7 @@ private function makeVacationRequests(Table $table):void { 'columns' => json_encode(array_values(array_map(function ($col) { return $col->getId(); }, $columns))), - 'sort' => json_encode([["columnId" => -3, "mode" => "ASC"]]), + 'sort' => json_encode([["columnId" => $columns['dateRequest']->getId(), "mode" => "ASC"]]), 'filter' => json_encode([[["columnId" => $columns['approved']->getId(), "operator" => "is-equal", "value" => "@checked"]], [["columnId" => $columns['approved']->getId(), "operator" => "is-equal", "value" => "@unchecked"]]]), ] );