Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable keyguard for toggle chat #1585

Merged
merged 1 commit into from Sep 17, 2021
Merged

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 16, 2021

show the lockscreen when switching to chat in a call that was opened by notification before the phone was unlocked.

Signed-off-by: Marcel Hibbe dev@mhibbe.de

@mahibi mahibi added the 3. to review Waiting for reviews label Sep 16, 2021
show the lockscreen when switching to chat in a call that was opened by notification before the phone was unlocked.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the bugfix/noid/showKeyguardForToggleChat branch from f0161a9 to 69bcd6e Compare September 17, 2021 12:59
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1585-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings266266
Errors33

SpotBugs (new)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 138
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 168
Performance Warnings 37
Security Warnings 4
Dodgy code Warnings 225
Total 595

SpotBugs (master)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 138
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 168
Performance Warnings 37
Security Warnings 4
Dodgy code Warnings 225
Total 595

@mahibi mahibi added this to the 12.3.0 milestone Sep 17, 2021
@mahibi mahibi merged commit caa8915 into master Sep 17, 2021
12 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/showKeyguardForToggleChat branch September 17, 2021 13:31
@nickvergessen
Copy link
Member

/backport to stable-12.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants