Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom permission for unfiltered broadcast receiver in CallActivity #2148

Merged
merged 1 commit into from Jun 23, 2022

Conversation

AlvaroBrey
Copy link
Member

No description provided.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2148-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings122122
Errors22

SpotBugs (new)

Warning Type Number
Bad practice Warnings 8
Correctness Warnings 35
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 23
Performance Warnings 23
Security Warnings 2
Dodgy code Warnings 72
Total 174

SpotBugs (master)

Warning Type Number
Bad practice Warnings 8
Correctness Warnings 35
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 23
Performance Warnings 23
Security Warnings 2
Dodgy code Warnings 72
Total 174

def localBroadcastPermission = "com.nextcloud.talk.permission.PRIVATE_BROADCAST"
manifestPlaceholders.broadcastPermission = localBroadcastPermission
buildConfigField "String", "PERMISSION_LOCAL_BROADCAST", "\"${localBroadcastPermission}\""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone knows a better way to have the constant accessible both in the manifest and in the code, please tell me, I don't really like this.

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Jun 15, 2022
@AndyScherzinger AndyScherzinger added this to the 14.1.0 milestone Jun 15, 2022
@AndyScherzinger
Copy link
Member

So merge?

@AlvaroBrey AlvaroBrey merged commit c4d9105 into master Jun 23, 2022
12 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/callactivity-receiver branch June 23, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants