New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom permission for unfiltered broadcast receiver in CallActivity #2148
Conversation
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2148-talk.apk |
Lint
SpotBugs (new)
SpotBugs (master)
|
| def localBroadcastPermission = "com.nextcloud.talk.permission.PRIVATE_BROADCAST" | ||
| manifestPlaceholders.broadcastPermission = localBroadcastPermission | ||
| buildConfigField "String", "PERMISSION_LOCAL_BROADCAST", "\"${localBroadcastPermission}\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anyone knows a better way to have the constant accessible both in the manifest and in the code, please tell me, I don't really like this.
|
So merge? |

No description provided.