Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/open notification #2598

Merged
merged 3 commits into from Nov 30, 2022
Merged

Bugfix/open notification #2598

merged 3 commits into from Nov 30, 2022

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Nov 29, 2022

No description provided.

@mahibi mahibi added the 3. to review Waiting for reviews label Nov 29, 2022
@mahibi mahibi added this to the 15.0.2 milestone Nov 29, 2022
@mahibi mahibi self-assigned this Nov 29, 2022
@mahibi
Copy link
Collaborator Author

mahibi commented Nov 29, 2022

/backport to stable-15.0

@mahibi mahibi marked this pull request as ready for review November 29, 2022 16:23
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@timkrueger timkrueger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mahibi

@mahibi
Copy link
Collaborator Author

mahibi commented Nov 30, 2022

/rebase

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
add logging

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2598-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link

Codacy

Lint

TypemasterPR
Warnings112112
Errors11

SpotBugs

CategoryBaseNew
Bad practice44
Correctness3131
Dodgy code268268
Experimental22
Internationalization77
Malicious code vulnerability5353
Performance2222
Security22
Total389389

@mahibi mahibi merged commit b3ba468 into master Nov 30, 2022
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/openNotification branch November 30, 2022 13:01
@mahibi mahibi modified the milestones: 15.0.2, 15.1.0 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants