Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1123
In
startReceivingChatMessagesFromMessagesId
we only check formessage.timestamp > _room.lastActivity
, in all other places (getInitialChatHistory
for example) we check for>=
. When we already received a room update, we won't mark it as read anymore, since thelastActivity
is equal to the processed message, but actually we want to update it even if the timestamps are equal, to remove the unread marker.