Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] display content first and then load menus #2228

Merged
merged 2 commits into from Mar 10, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 9, 2022

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #2226

@max-nextcloud
Copy link
Collaborator

I'm not entirely sure we want to backport this as it's only improving performance, not fixing a bug.
On the other hand the emoji picker which was introduced in stable23 takes most of the time when loading the menu bar. So you can also think of this as fixing a performance regression.

Rendering the menubar and menububble takes a significant amount of time.
First display the content and then render the menus.

Signed-off-by: Max <max@nextcloud.com>
Also rename `initialLoading` in `EditorWrapper` to `contentLoaded`.
This flag is set during the `initialLoading` state change.
It does indicates that the loading happened
Use the past tense to indicate that.

The editor wrapper is now loading in different steps.
The menus will load after the content.
So `content` seems more fitting then `initial`.

Signed-off-by: Max <max@nextcloud.com>
@blizzz
Copy link
Member

blizzz commented Mar 10, 2022

what's the state of this PR?

@juliushaertl
Copy link
Member

Yes, I'd vote for back porting since the emoji picker is quite a large chunk that gets loaded and might be a noticeable slowdown.

@juliushaertl
Copy link
Member

@max-nextcloud Conflicts were resolved, right? Please make sure to update the description then :)

@juliushaertl juliushaertl merged commit 54671bf into stable23 Mar 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/2226/stable23 branch March 10, 2022 13:25
@max-nextcloud
Copy link
Collaborator

thanks for taking care of this @juliushaertl and @blizzz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants