Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Favicon as Image #1407

Open
jotoeri opened this issue May 31, 2023 · 5 comments · May be fixed by #1549
Open

Provide Favicon as Image #1407

jotoeri opened this issue May 31, 2023 · 5 comments · May be fixed by #1549

Comments

@jotoeri
Copy link
Member

jotoeri commented May 31, 2023

Feature Request

Currently the provided QR-Code does not contain any image, resulting in apps just using any default image.
Nice gimmick would be, if the QR-Code provided the Image-URL to the Clouds Favicon (&image=URL within QR-Code), so the otp app has some customized appearance.

@ernolf
Copy link

ernolf commented Jul 29, 2024

Nice gimmick would be, if the QR-Code provided the Image-URL to the Clouds Favicon (&image=URL within QR-Code), so the otp app has some customized appearance.

The transfer of an image as an URL parameter is not included in the Key-Uri-Format specification. If you add an image URL of an svg element in the URL, then depending on the QR library used, the image can be processed in the QR code, as can be seen and tried out in this example QR code generator.
I am not aware of any TOTP app though, that takes over an icon in this way. If you know of an app that does this, please let me know.
I can, however, highly recommend the Aegis app to Android users. For each account, you can either take an icon from the community icon project or insert your own icon.

ernolf

@jotoeri
Copy link
Member Author

jotoeri commented Jul 31, 2024

FreeOTP does it e.g.
https://github.com/freeotp/freeotp-android/blob/master/URI.md#image

@ernolf
Copy link

ernolf commented Jul 31, 2024

Hi @jotoeri,

FreeOTP does it

Did you get it to work with any icon?

The example QR Code Generator I linked to, is from FreeOTP and shows the Icon inside of the QR Code but I was unable to get any image visible inside of the FreeOTP App. I have tried it with many different Icons, from FontAwsome as well.
I would like to understand why. If I know exactly if the Icon e.g. needs some treatment, I would try to implement this feature in the code, to make FreeOTP not look that sad. 😉
Unfortunately one cannot assign any icon in FreeOTP or change any other major setting. One can only edit the Isuer and the account name. Changing other values is not possible unless you have saved the secret somewhere else so that you can use the QR code generator to make subsequent changes to Digit (OTP token length) and HashAlgorithm. Or you enter everything by hand, which is possible too but then a subsequent editing is still not possible.
Compared to the range of functions, the setting options and the appearance of Aegis, FreeOTP is really pathetic!

@ernolf ernolf linked a pull request Aug 2, 2024 that will close this issue
@ernolf ernolf linked a pull request Aug 2, 2024 that will close this issue
@jotoeri
Copy link
Member Author

jotoeri commented Aug 8, 2024

Hmm, just seems like it needs to be a png or something similar. As i have a png as favicon on my cloud, it works. SVG also didnt work for me.

@ernolf
Copy link

ernolf commented Aug 10, 2024

seems like it needs to be a png

Yes. I got it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants