Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Adaption to U2F API v1.1 #47

Closed
2 of 5 tasks
go2sh opened this issue May 5, 2017 · 3 comments
Closed
2 of 5 tasks

Adaption to U2F API v1.1 #47

go2sh opened this issue May 5, 2017 · 3 comments

Comments

@go2sh
Copy link

go2sh commented May 5, 2017

This is a list of bugs currently in the U2F App which I found after a quick review.

  • Database needs to store transports presented by a registration response
  • Challenge page needs to show a single challenge value and a list of registered keys
  • u2f app's challenge page needs to properly call u2f api with the correctly provided values
  • Registration page needs to properly show registered keys and a single register request
  • u2f app's register page needs to properly call u2f api with the correctly provided values

This the thing with multiple challenges is cause for breaking multiple devices. There might be some more bugs related to the items above.
cc @ChristophWurst @LukasReschke

@zauguin
Copy link
Collaborator

zauguin commented May 9, 2017

@go2sh The first point isn't a bug, because storing the transports is optional according to the U2F spec.
The second and third should be fixed with #49.
Could you explain the last two points? I haven't really looked into it but I couldn't find fundamental problems with the registration on a first glance.

@ChristophWurst
Copy link
Member

@go2sh @zauguin could you please re-check? I've swapped the u2f lib in #74, hopefully that fixed some of the items on your list.

@ChristophWurst
Copy link
Member

I'm closing this because I got no response in more than three months. If this is still an issue, please let me know and I'll re-open.

Thank you for your report.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants