Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IP version preference code #1033

Closed
wants to merge 1 commit into from
Closed

Conversation

@staticsafe
Copy link

staticsafe commented Jan 14, 2020

There is no discernible and good reason that the user's system IP version preference should be modified from the default and especially not without notifying the user that such a drastic change was made to their system.

In addition, if this was added to solve some sort of networking issue with the user's system, that is outside the scope of a script like this.

There is no discernible and good reason that the user's systen IP version preference should be modified from the default.
In addition, if this was added to solve some sort of networking issue, that is outside the scope of a script like this.
@enoch85

This comment has been minimized.

Copy link
Member

enoch85 commented Jan 15, 2020

Hi,

Thanks for your PR!

As you can read in the README the installation happens in two sets of scripts. The second script sets it back to the original setting at the end. It's just a preference, nothing hard coded.

The script is developed to work with IPv4 and that's why I added that at the top. It has nothing to do with any Dev-environment.

Sorry, but I will not merge this PR.

@staticsafe

This comment has been minimized.

Copy link
Author

staticsafe commented Jan 15, 2020

My bad, I missed the README and the second script. Could you please explain why the script needs to work with IPv4 by changing gai.conf (even temporarily for runtime duration)?

@enoch85

This comment has been minimized.

Copy link
Member

enoch85 commented Jan 15, 2020

Could you please explain why the script needs to work with IPv4 by changing gai.conf

It has to do with the functions regarding the network, checks and so forth. I don't remember 100% to be honest, but I remember that when I removed it, weird stuff started to happen.

EDIT: Hmm, now when I think about it, maybe it was the some mirrors that didn't like IPv6 and updates failed.

Anyway, it's there for a reason.

@enoch85 enoch85 closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.