Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove IP version preference code #1033
There is no discernible and good reason that the user's system IP version preference should be modified from the default and especially not without notifying the user that such a drastic change was made to their system.
In addition, if this was added to solve some sort of networking issue with the user's system, that is outside the scope of a script like this.
There is no discernible and good reason that the user's systen IP version preference should be modified from the default. In addition, if this was added to solve some sort of networking issue, that is outside the scope of a script like this.
Thanks for your PR!
As you can read in the README the installation happens in two sets of scripts. The second script sets it back to the original setting at the end. It's just a preference, nothing hard coded.
The script is developed to work with IPv4 and that's why I added that at the top. It has nothing to do with any Dev-environment.
Sorry, but I will not merge this PR.
It has to do with the functions regarding the network, checks and so forth. I don't remember 100% to be honest, but I remember that when I removed it, weird stuff started to happen.
EDIT: Hmm, now when I think about it, maybe it was the some mirrors that didn't like IPv6 and updates failed.
Anyway, it's there for a reason.