New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Switch to go 1.17" #618
Conversation
This reverts commit fe5e5b4. We switch back to 1.16.5 just for testing. It was known to work with 1.35.0. If it works, we need to try 1.16.10 then.
Running pr-618/SNAPSHOT-9483d8b version on EdgeRouter for about 33 hours and having no issue. |
Same here. Runs here for over 30 hours without interruption. |
With 9483 edgerouter working smoothly. |
This is the latest release in 1.16.
Please remove winio imported pipe test so we get it green. |
If some of you can test the same version with Go 1.16.10 and report if it still works, it would be helpful. While we can surely stay with Go 1.16.10 if the issue is with Go 1.17, we cannot keep an outdated compiler. If it works with Go 1.16.10, it gives us some time to understand what broke between Go 1.16 and Go 1.17. If it does not work, we have even fewer changes to understand.
|
Not enough to make it green. Maybe I can just disable the static check for Windows? Getting green is not that important or do you plan to merge if OK? |
Ok to disable windows and yes, will merge regardless. |
9e5e67c
to
6da13a4
Compare
I may be missing something here but:
|
Looks like the new commit on this PR makes the old snapshot unable to be accessed. When you try to access it shows Access Denied like https://snapshot.nextdns.io/pr-618/nextdns-SNAPSHOT-9483d8b_linux_mips64le_softfloat.tar.gz. The newest commit in this PR using Go 1.16.10 : |
Okay -- running that version now for ~24hr |
Nov 27 17:09:49 DNS-server nextdns[1754]: NextDNS 0.0.0-SNAPSHOT-9483d8b/linux stopped |
OK, only recently accessed tarballs are still in the cache. If you happen to want to rollback to the previous version, you can fetch it from here: https://github.com/nextdns/nextdns/actions/runs/1510763854 (the dist archive). I let another person confirm the problem appears with f535f8c while it did not happen with 9483d8b before reaching any conclusion. |
If this snapshot fails for you, feel free to revert to the one in #620. I'll keep #620 unmodified from now on and will try to bisect the issue using #618. Currently, everyone reported that Go 1.16.5 works and @deman3417 reported that Go 1.16.10 fails. I am waiting for a second report to try Go 1.16.8. A lot of changes where introduced in 1.16.10, but picking 1.16.8 will reduce the number of tries is the problem is in a previous version. |
So far f535f8c makes no problem on my side. Several Nov 27 22:53:31 ubnt nextdns[9099]: Starting NextDNS 0.0.0-SNAPSHOT-f535f8c/linux on :53 |
I ran another log. |
Running f535f8c without interruption for more than 18 hours now. |
f535f8c seems fine here as well (~18hrs)
|
Running f535f8c without interruption for more than 40 hours now. |
This one seems good enough until we figure the root cause. Let's merge it. |
f535f8c is fine as well - not a single occurence of error for the last 2 days. |
Here is an update from my side. It's running fine for 6 days now on my USG-3P v4.4.56. The high CPU as shown by @Tuinslak never happened on my device, also not with the old version. The only problems I had were the "context deadline exceeded" messages resulting in a temporal DNS resolving outage on my network. |
I do get those messages too, but I also get these on Linux servers (= non-routers) and doesn't seem to be breaking anything.
for what it's worth, the version of my edge router lite:
|
so far, so good with f535f8c - over 5 days and not a single issue on ER-X. |
I can update this is still an issue with v1.37.11 (Go 1.18). Upgrading causes 100% CPU usage spike within 1 hour. |
This reverts commit fe5e5b4. We
switch back to 1.16.5 just for testing. It was known to work with
1.35.0. If it works, we need to try 1.16.10 then.