Skip to content

Optimization: Rm use of BufReader and lazily allocate space for BytesMut in TestRunner::run_test_inner #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Oct 5, 2022

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

that has at least 4096 free space.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #560 (9d8b0fb) into main (c18d3ae) will increase coverage by 0.01%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   77.17%   77.18%   +0.01%     
==========================================
  Files          49       49              
  Lines       11029    11034       +5     
==========================================
+ Hits         8512     8517       +5     
  Misses       2517     2517              
Impacted Files Coverage Δ
nextest-runner/src/runner.rs 84.89% <90.90%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sunshowers
Copy link
Member

Looks great, thanks!

@sunshowers sunshowers merged commit 22105ef into nextest-rs:main Oct 5, 2022
@NobodyXu NobodyXu deleted the optimize branch October 6, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants