Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the File Reader directory/filter pattern/username/password once per poll, not once on deploy #3045

Closed
rbeckman-nextgen opened this issue May 11, 2020 · 6 comments
Milestone

Comments

@rbeckman-nextgen
Copy link
Collaborator

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Right now if you use global map variables in the directory / filename filter pattern, you might expect the channel to update the fields on subsequent polling periods. However right now they're just replaced once on channel deploy and kept static until the next deploy.

Imported Issue. Original Details:
Jira Issue Key: MIRTH-3131
Reporter: narupley
Created: 2014-01-27T14:25:51.000-0800

@rbeckman-nextgen rbeckman-nextgen added this to the 3.2.0 milestone May 11, 2020
@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

I vote for this option to be in the next release and provide an option to the user to either choose ON DEPLOY or ON POLLING for the directory and filename filter pattern.

Imported Comment. Original Details:
Author: stickybandit
Created: 2014-01-27T14:55:53.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Got a customer looking for this functionality as well. I see merit to having this be optional- on deploy / on polling

Imported Comment. Original Details:
Author: johnhd
Created: 2014-06-30T08:06:53.000-0700

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

I can definitely see there being cases when the user would want to opt out of template replacement per polling vs. on deploy. I initially thought we should include this as an option under the polling settings, but since it only applies to this connector, maybe it makes sense to add a separate subdivision within the panel. Any thoughts on where these settings should be housed?

Imported Comment. Original Details:
Author: jaysenp
Created: 2014-10-17T14:24:47.000-0700

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

It makes sense for this connector to always replace on poll. Can anyone think of a use case where they would use it on deploy?

Imported Comment. Original Details:
Author: jaysenp
Created: 2014-12-30T15:24:26.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

The File Reader will now replace the directory, filter pattern, username and passwords on each poll.

The original replacement code was moved to the onStart task and global variables have been created to store the additional replacement fields on poll. The method signature, getConnectionPool, had the connectorProperties argument removed in lieu of passing in the username and password directly since these are the only pieces of information used from the properties. All code that referenced this method were updated to conform to the changes.

Imported Comment. Original Details:
Author: jaysenp
Created: 2015-01-06T17:19:15.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Verified that replaceable File Reader fields are now replaced each time a poll is performed, rather than once when the channel is deployed.

Imported Comment. Original Details:
Author: narupley
Created: 2015-02-09T08:13:38.000-0800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.