Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Always choose" option for importing code template libraries along with channels affects the export user preference #3738

Closed
rbeckman-nextgen opened this issue May 11, 2020 · 6 comments
Milestone

Comments

@rbeckman-nextgen
Copy link
Collaborator

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Export code template preference is being updated while selecting "Always choose this option by default" during Import

Imported Issue. Original Details:
Jira Issue Key: MIRTH-3855
Reporter: narupley
Created: 2015-12-22T08:38:53.000-0800

@rbeckman-nextgen rbeckman-nextgen added this to the 3.4.0 milestone May 11, 2020
@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Fixed in revisions 7872/7873.

Imported Comment. Original Details:
Author: narupley
Created: 2015-12-22T08:42:32.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Server(s) and URLs Used: virtual Window 7 with JRE version 1.8.0_71-b15
Version(s)/Build(s) to reproduce failure: mirthconnect-3.3.1.7856.b91-windows-x64
Version(s)/Build(s) to verify fixes:
mirthconnect-3.3.1.7901.b100-windows-x64
mirthconnect-3.4.0.7892.b1858-windows-x64
How Tested (list tests run):

  • Mirth Connect Settings > Administrator > System Preferences > Set the followings:
    Import code template libraries with channels = “Ask”
    Export code template libraries with channels = “Ask”
  • Save & Refresh, take screenshot for record
  • Mirth Connect Channels > Import Channel > select a channel with Code Template to import
  • Select option “Always choose this option by default in the future” & click YES to import
  • Save Channel
  • Mirth Connect Settings > Administrator > System Preferences > Verify Import & Export settings

Verified Fixed: Import preference is properly updated as selected

Imported Comment. Original Details:
Author: minht
Created: 2016-02-04T10:24:03.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Verified Import Code Template preference is correctly updated with MC331.7901.b100 & MC340.7892.b1858

Imported Comment. Original Details:
Author: minht
Created: 2016-02-04T10:40:13.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

The original issue was fixed, however, the "Always choose" option does not take affect in the current selection (if import more than one channel at the same time, each with code template, user will get prompted for each one, previous preference will be overwritten) . Need DEV's feedback if this behavior should be corrected.

Imported Comment. Original Details:
Author: minht
Created: 2016-02-05T14:01:17.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Hmm I think that's fine for now. The reason this is happening is because the code that imports channels is called via SwingUtilities.invokeLater. That's necessary because of a separate bug only on OSX. However it means that in this case, if you multi-import, it will show you that code template libraries dialog for every channel, but only the first time.

Imported Comment. Original Details:
Author: narupley
Created: 2016-02-08T11:37:40.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

  • Original issue is FIXED
  • Note on observation:
    "Always choose" option does not take affect in the current import selection (if import more than one channel at the same time, user will get prompted for each one, previous preference will be overwritten).

Imported Comment. Original Details:
Author: minht
Created: 2016-02-09T12:00:11.000-0800

@cturczynskyj cturczynskyj modified the milestones: 3.4.0, 3.3.2 Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.