Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all messages Message task removes messages from two channels rather than one #3758

Closed
rbeckman-nextgen opened this issue May 11, 2020 · 9 comments
Milestone

Comments

@rbeckman-nextgen
Copy link
Collaborator

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Imported Issue. Original Details:
Jira Issue Key: MIRTH-3876
Reporter: mpang
Created: 2016-01-29T15:01:16.000-0800

@rbeckman-nextgen rbeckman-nextgen added this to the 3.4.0 milestone May 11, 2020
@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

  1. Using the shift key, select three channels
  2. Open one channel, remove all messages from message tasks
  3. View dashboard to see that messages have been removed from two channels

Imported Comment. Original Details:
Author: mpang
Created: 2016-01-29T15:05:25.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

The second channel cleared seems unpredictable. Selecting channel Sample - Hello World v3 in step two causes messages to clear in channels Sample - Hello World v3 and HL7 to MR

Imported Comment. Original Details:
Author: mpang
Created: 2016-01-29T15:05:40.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Event log shows a "Clear messages" event on two channel IDs

Imported Comment. Original Details:
Author: mpang
Created: 2016-01-29T15:05:59.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

This is a serious issue. We lost two weeks of data. When you search for message within a channel and Remove All Messages or Remove Results, there should be no way you are deleting messages from another channel.

Imported Comment. Original Details:
Author: kirbykn
Created: 2016-02-01T05:32:48.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Looks like this regression was added with MIRTH-2288. As a workaround in the meantime, just make sure not to have any channel selected on the Channels view first. You can do that by clicking on the blank space below the channels in the table. Or, create a new dummy channel, select it, and delete it.

Imported Comment. Original Details:
Author: narupley
Created: 2016-02-01T08:04:34.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Fixed in revision 7895. Rewrote logic in doRemoveAllMessages method so it no longer uses the channel list selection.

Imported Comment. Original Details:
Author: eduardoa
Created: 2016-02-01T12:05:55.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Thanks Eduardo,

Can you tell me how I know which update this fix will be included in?

Imported Comment. Original Details:
Author: kirbykn2
Created: 2016-02-01T12:24:07.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

OS(s) and JRE version: virtual Window 7 with JRE version 1.8.0_71-b15
Version(s)/Build(s) to reproduce failure: mirthconnect-3.3.1.7856.b91-windows-x64
Version(s)/Build(s) to verify fixes: mirthconnect-3.3.1.7901.b100-windows-x64
How Tested (list tests run):

  • Create 3 test channels with Source/Destination = JS Reader/Writer
    All without poll once on start
    Test1 = send every 10 seconds
    Test2 = send every 20 seconds
    Test3 = send every 30 seconds
  • Channels > Deploy test channels
  • Channels > select Test1, make sure the channel line is highlighted
  • Dashboard > Stop test channels > Record the current statistics
  • Dashboard > select Test3 > Remove All Messages > Record the new statistics
  • Events > select the latest Name = “Clear messages”, verify “channelIds” value

Observation: In MC331.7856

  • Messages were removed from both Test1 and Test3 (only select to remove msg from Test3)
  • “Clear Messages” event listed channelsID of both Test3 and Test1
  • Whichever channel selected/highlighted in Channels view is being affected during “Remove All Messages” operation.

Verified Fixed: problem no longer exhibits in MC332 (3.3.1.7901.b100)

  • Only messages from Test3 were removed
  • “Clear messages” Event showed the correct channelID for the operation

Imported Comment. Original Details:
Author: minht
Created: 2016-02-08T17:29:02.000-0800

@rbeckman-nextgen
Copy link
Collaborator Author

@rbeckman-nextgen rbeckman-nextgen commented May 11, 2020

Verified FIX with mirthconnect-3.3.1.7901.b100-windows-x64

Imported Comment. Original Details:
Author: minht
Created: 2016-02-08T17:33:12.000-0800

@cturczynskyj cturczynskyj modified the milestones: 3.4.0, 3.3.2 Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.