Permalink
Browse files

Revert "MigrationsExtension: add default value for migrations directory"

This reverts commit 1ddaa96.
  • Loading branch information...
JanTvrdik committed Jan 22, 2018
1 parent f07e52e commit ce8ac5e8933ffcb0c110e3fe12c82a014357cfe9
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/Bridges/NetteDI/MigrationsExtension.php
@@ -18,7 +18,7 @@ class MigrationsExtension extends Nette\DI\CompilerExtension
{
/** @var array */
public $defaults = [
'dir' => '%appDir%/../migrations',
'dir' => NULL,
'phpParams' => [],
'driver' => NULL,
'dbal' => NULL,

2 comments on commit ce8ac5e

@hrach

This comment has been minimized.

Show comment
Hide comment
@hrach

hrach Jan 22, 2018

Member

Why's that?

Member

hrach replied Jan 22, 2018

Why's that?

@JanTvrdik

This comment has been minimized.

Show comment
Hide comment
@JanTvrdik

JanTvrdik Jan 22, 2018

Member

Because it did not work at all. It only created illusion of working =)
The %appDir% is not resolved, so the dir path is a literal string %appDir%/../migrations which is resolved to just migrations, meaning it's actually relative to current working directory, not to appDir.

Member

JanTvrdik replied Jan 22, 2018

Because it did not work at all. It only created illusion of working =)
The %appDir% is not resolved, so the dir path is a literal string %appDir%/../migrations which is resolved to just migrations, meaning it's actually relative to current working directory, not to appDir.

Please sign in to comment.