New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple plan impl #69

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@Mikulas
Contributor

Mikulas commented Apr 22, 2017

Closes #61

Intentionally very simple implementation. More complex would require many changes to the core, such as splitting OrderResolver. This was started at https://github.com/Mikulas/migrations/tree/pr/exec-plan.

This proposed solution is almost backwards compatible, with single exception of extending existing IConfiguration with getPlanFile method. However, the method is allowed to return NULL, in which case migrations completely skip all Plan code.

Plan entries are created only with migrations:create symfony command. The Plan is checked for validity whenever Engine\Runner::run is invoked.

IMO this solves the merge/rebase problem this was initially intended for, with minimal changes to the codebase.

screenshot 2017-04-22 14 10 29

@hrach hrach requested a review from JanTvrdik Apr 22, 2017

@Mikulas

This comment has been minimized.

Show comment
Hide comment
@Mikulas

Mikulas Jul 27, 2017

Contributor

Ok so this above is my proposition. Any better implementation would require a pretty much complete rewrite of the core.

Contributor

Mikulas commented Jul 27, 2017

Ok so this above is my proposition. Any better implementation would require a pretty much complete rewrite of the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment