Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refreshAll method #219

Closed
wants to merge 1 commit into from
Closed

add refreshAll method #219

wants to merge 1 commit into from

Conversation

@matej21
Copy link
Member

matej21 commented Apr 22, 2017

No description provided.

@matej21 matej21 force-pushed the matej21:feature/refresh branch 2 times, most recently from d0db628 to d7dedb8 Apr 22, 2017
if (!$metadataProperty->isVirtual && isset($data[$name])) {
if (isset($this->data[$name]) && $this->data[$name] instanceof OneHasOne) {
$this->data[$name]->set(NULL, TRUE);

This comment has been minimized.

Copy link
@hrach

hrach Apr 22, 2017

Member

lowercased null, true :)

@@ -234,6 +234,15 @@ public function trackEntity(IEntity $entity)
}


public function clean()

This comment has been minimized.

Copy link
@hrach

hrach Apr 22, 2017

Member

Please put @internal phpdoc.

@hrach hrach added the feature label Apr 22, 2017
@hrach hrach added this to the v3.0 milestone Apr 22, 2017
@hrach
Copy link
Member

hrach commented Apr 22, 2017

Some doc would be also nice :-)

@matej21 matej21 force-pushed the matej21:feature/refresh branch 2 times, most recently from 2cccad3 to 3103b3c Apr 22, 2017
@hrach
Copy link
Member

hrach commented Apr 29, 2017

Could you please fix the tests?

This was referenced Apr 29, 2017
@matej21 matej21 force-pushed the matej21:feature/refresh branch from 3103b3c to db778f4 May 3, 2017
@matej21
Copy link
Member Author

matej21 commented May 3, 2017

@hrach fixed

@hrach
Copy link
Member

hrach commented May 6, 2017

Merged in #227

@hrach hrach closed this May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.