New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refreshAll method #219

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@matej21
Contributor

matej21 commented Apr 22, 2017

No description provided.

Show outdated Hide outdated src/Entity/AbstractEntity.php
if (!$metadataProperty->isVirtual && isset($data[$name])) {
if (isset($this->data[$name]) && $this->data[$name] instanceof OneHasOne) {
$this->data[$name]->set(NULL, TRUE);

This comment has been minimized.

@hrach

hrach Apr 22, 2017

Member

lowercased null, true :)

@hrach

hrach Apr 22, 2017

Member

lowercased null, true :)

Show outdated Hide outdated src/Relationships/HasMany.php
@@ -234,6 +234,15 @@ public function trackEntity(IEntity $entity)
}
public function clean()

This comment has been minimized.

@hrach

hrach Apr 22, 2017

Member

Please put @Internal phpdoc.

@hrach

hrach Apr 22, 2017

Member

Please put @Internal phpdoc.

@hrach hrach added the 1-feature label Apr 22, 2017

@hrach hrach added this to the v3.0 milestone Apr 22, 2017

@hrach

This comment has been minimized.

Show comment
Hide comment
@hrach

hrach Apr 22, 2017

Member

Some doc would be also nice :-)

Member

hrach commented Apr 22, 2017

Some doc would be also nice :-)

@hrach

This comment has been minimized.

Show comment
Hide comment
@hrach

hrach Apr 29, 2017

Member

Could you please fix the tests?

Member

hrach commented Apr 29, 2017

Could you please fix the tests?

This was referenced Apr 29, 2017

@matej21

This comment has been minimized.

Show comment
Hide comment
@matej21

matej21 May 3, 2017

Contributor

@hrach fixed

Contributor

matej21 commented May 3, 2017

@hrach fixed

@hrach

This comment has been minimized.

Show comment
Hide comment
@hrach

hrach May 6, 2017

Member

Merged in #227

Member

hrach commented May 6, 2017

Merged in #227

@hrach hrach closed this May 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment