New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring #222

Merged
merged 20 commits into from Apr 25, 2017

Conversation

Projects
None yet
2 participants
@matej21
Contributor

matej21 commented Apr 22, 2017

No description provided.

@hrach hrach self-requested a review Apr 24, 2017

@hrach

just some coding style things, otherwise one big 👍 👏

Show outdated Hide outdated src/Mapper/Dbal/DbalMapper.php
{
$key = md5(json_encode($connection->getConfig()));
$this->connection = $connection;
$this->cache = $cache->derive('mapper.' . $key);
$this->mapperCoordinator = $mapperCoordinator;

This comment has been minimized.

@hrach

hrach Apr 24, 2017

Member

plese move the assign one line above to match the arguments :-)

@hrach

hrach Apr 24, 2017

Member

plese move the assign one line above to match the arguments :-)

Show outdated Hide outdated src/Mapper/Dbal/DbalMapperCoordinator.php
class DbalMapperCoordinator
{

This comment has been minimized.

@hrach

hrach Apr 24, 2017

Member

drop the line

@hrach

hrach Apr 24, 2017

Member

drop the line

@@ -0,0 +1,50 @@
<?php declare(strict_types = 1);

This comment has been minimized.

@hrach

hrach Apr 24, 2017

Member

missing phpdoc

@hrach

hrach Apr 24, 2017

Member

missing phpdoc

Show outdated Hide outdated src/Mapper/Dbal/DbalMapperCoordinator.php
$this->transactionActive = false;
}
}

This comment has been minimized.

@hrach

hrach Apr 24, 2017

Member

drop the empty line

@hrach

hrach Apr 24, 2017

Member

drop the empty line

Show outdated Hide outdated src/Mapper/Dbal/StorageReflection/StorageReflection.php
@@ -15,7 +15,7 @@
use Nextras\Dbal\Platforms\IPlatform;
use Nextras\Orm\InvalidArgumentException;
use Nextras\Orm\InvalidStateException;
use Nextras\Orm\Mapper\IMapper;
use Nextras\Orm;

This comment has been minimized.

@hrach

hrach Apr 24, 2017

Member

is it correctly sorted?

@hrach

hrach Apr 24, 2017

Member

is it correctly sorted?

Show outdated Hide outdated src/Repository/IdentityMap.php
public function __construct(IRepository $repository, IDependencyProvider $dependencyProvider = null)
public function __construct(IRepository $repository)

This comment has been minimized.

@hrach

hrach Apr 24, 2017

Member

empty line before consturctor

@hrach

hrach Apr 24, 2017

Member

empty line before consturctor

@@ -60,12 +53,6 @@ public function setRepository(IRepository $repository);
public function getRepository(): IRepository;
public function getTableName(): string;

This comment has been minimized.

@hrach

hrach Apr 24, 2017

Member

why is this method removed?

@hrach

hrach Apr 24, 2017

Member

why is this method removed?

This comment has been minimized.

@hrach

hrach Apr 24, 2017

Member

but probably ok :)

@hrach

hrach Apr 24, 2017

Member

but probably ok :)

This comment has been minimized.

@matej21

matej21 Apr 25, 2017

Contributor

it is only used by a mapper

@matej21

matej21 Apr 25, 2017

Contributor

it is only used by a mapper

@matej21

This comment has been minimized.

Show comment
Hide comment
@matej21

matej21 Apr 25, 2017

Contributor

@hrach done

Contributor

matej21 commented Apr 25, 2017

@hrach done

@hrach

This comment has been minimized.

Show comment
Hide comment
@hrach

hrach Apr 25, 2017

Member

🎉
thanks!

Member

hrach commented Apr 25, 2017

🎉
thanks!

@hrach hrach merged commit 540c261 into nextras:master Apr 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.07%) to 93.957%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment