New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong timeshift when column is type of DATE #329

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Sitole
Copy link
Contributor

Sitole commented Jan 6, 2019

Fixed #328.

@Sitole

This comment has been minimized.

Copy link
Contributor

Sitole commented Jan 8, 2019

Ping @hrach

@hrach

This comment has been minimized.

Copy link
Member

hrach commented Jan 8, 2019

Thanks for the PR, it misses fix for Postgre & MS SQL and some tests. You may do it or I will prepare it :)

@Sitole

This comment has been minimized.

Copy link
Contributor

Sitole commented Jan 8, 2019

I have only little bit experience with MS SQL and Postgre. Fix may be same.

Can you write tests? I do not have experience with that, yet.

@hrach

This comment has been minimized.

Copy link
Member

hrach commented Jan 9, 2019

Thanks, merged here with tests: e179903

@hrach hrach closed this Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment