filter: Update --min-length help message
#1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I also update the Line 431 in 14f5ce4 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1422 +/- ##
=======================================
Coverage 68.50% 68.50%
=======================================
Files 69 69
Lines 7537 7537
Branches 1846 1846
=======================================
Hits 5163 5163
Misses 2091 2091
Partials 283 283 ☔ View full report in Codecov by Sentry. |
|
That is unintuitive! I think good to clarify in both the help and report messages. |
|
Maybe also worth noting that it's case-insensitive. |
Explicitly state that the minimum length only counts the standard nucleotide characters A, C, G, or T (case-insensitive). This has been the behavior since version 3.0.3.dev1, but has never been explicitly documented outside of the `filter_by_sequence_length` docstring.
joverlee521
force-pushed
the
filter-min-length-message
branch
from
623ecd4
to
b86e997
Compare
victorlin
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Explicitly state that the minimum length only counts the standard nucleotide characters (A, C, G, or T).
This has been the behavior since version 3.0.3.dev1, but has never been explicitly documented outside of the
filter_by_sequence_lengthdocstring.Related issue(s)
Prompted by @j23414's conversation in nextstrain/dengue#28 (comment)
Checklist