Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Support networkx major version 3 #1534

Merged
merged 1 commit into from
Jul 11, 2024
Merged

chore(deps): Support networkx major version 3 #1534

merged 1 commit into from
Jul 11, 2024

Conversation

corneliusroemer
Copy link
Member

@corneliusroemer corneliusroemer commented Jul 11, 2024

No relevant breaking changes per changelog: https://networkx.org/documentation/stable/release/release_3.0.html#api-changes

We only use networkx in one place.

Basically just housekeeping to relax upward pins we don't need.

Description of proposed changes

Related issue(s)

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

@corneliusroemer corneliusroemer changed the title chore(deps): Allow networkx major version 3 chore(deps): Support networkx major version 3 Jul 11, 2024
@victorlin victorlin mentioned this pull request Jul 11, 2024
6 tasks
@corneliusroemer
Copy link
Member Author

Feel free to merge @victorlin - tests pass with latest networkx and there's been no code changes, so we should be all good. Changelog doesn't contain anything of concern.

Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force-pushed onto latest master.

The single place where networkx is used is covered by tests, so this looks good to go.

@victorlin victorlin merged commit 7759f30 into master Jul 11, 2024
22 checks passed
@victorlin victorlin deleted the networkx3 branch July 11, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants