Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export traits which are filters but not colorings #442

Merged
merged 1 commit into from Feb 18, 2020

Conversation

jameshadfield
Copy link
Member

Previous behavior of augur export v2 was to ignore traits which were defined as filters (via auspice config JSON) if they weren't exported as colorings. Here we allow the export of such traits, and add a test build. Auspice requires no changes to display these. All test builds pass.

Previous behavior of `augur export v2` was to ignore traits which were defined as filters (via auspice config JSON) if they weren't exported as colorings. Here we allow the export of such traits, and add a test build. Auspice requires no changes to display these.
@jameshadfield
Copy link
Member Author

@emmahodcroft does this look ok to you?

@emmahodcroft
Copy link
Member

Oh man - I'm sorry @jameshadfield ! So much coming in right now I totally missed this.
Yes, this looks good to me, and I think it's fair. It's still explicitly requested by the user, so they should know it'll be exported (rather than 'secret' data export as we've worried about) and I can definitely see the functionality.
Thanks for tackling this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants