Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make calendarToNumeric parse negative dates #627

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
2 participants
@rneher
Copy link
Member

commented Aug 15, 2018

this prevents negative dates to defaulting to 1970. It also no longer pretends to have month and day for BC dates.

@jameshadfield

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

👍 thanks @rneher

@jameshadfield jameshadfield merged commit 2bb17f0 into master Aug 17, 2018

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jameshadfield jameshadfield deleted the negative_dates branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.