Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/components/tree/phyloTree/grid.js: #725

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@rneher
Copy link
Member

commented May 16, 2019

If the major grid is 5 or 10y use 5 minor ticks instead of 4. This avoids the odd case when our grid lines in the tree are:
2010, 2011.25, 2012.5, 2013.75 and 2015
and replaces this in favor of
2010, 2011, 2012, 2013, 2014 and 2015
(analogously for 10y intervals).

rneher and others added some commits May 16, 2019

@trvrb

This comment has been minimized.

Copy link
Member

commented May 16, 2019

This is great @rneher. Thanks for the fix. I tested and this works well. Merging now.

@trvrb trvrb merged commit 2a042d9 into master May 16, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@trvrb trvrb deleted the fiveMinorTicks branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.