New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the geometry documentation as agreed upon at 2014 NIAC #397

Closed
prjemian opened this Issue May 20, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@prjemian
Contributor

prjemian commented May 20, 2015

The specification of geometry and axis coordinates needs to be clarified in the manual, as revisions were agreed upon at the 2014 NIAC meeting.

Use this as the starting point
http://www.bernstein-plus-sons.com/software/CBF/doc/cif_img_1.7.8.html#axis

@prjemian prjemian self-assigned this May 20, 2015

@yayahjb

This comment has been minimized.

Contributor

yayahjb commented May 20, 2015

See also the attached Dectris document, and the history of the discussion at
https://sites.google.com/site/nexuscbf -- HJB

On Wed, May 20, 2015 at 8:06 AM, Pete R Jemian notifications@github.com
wrote:

The specification of geometry and axis coordinates needs to be clarified
in the manual, as revisions were agreed upon at the 2014 NIAC meeting.

Use this as the starting point
http://www.bernstein-plus-sons.com/software/CBF/doc/cif_img_1.7.8.html#axis


Reply to this email directly or view it on GitHub
#397.

@prjemian

This comment has been minimized.

Contributor

prjemian commented Jun 1, 2015

see #195

@zjttoefs

This comment has been minimized.

Contributor

zjttoefs commented Oct 1, 2015

Will add some information and links here to aid to updating of the manual.

@zjttoefs

This comment has been minimized.

Contributor

zjttoefs commented Oct 6, 2015

The code to convert CBF to NeXus is deeply bundled in CBFlib. You'll find evidence it exists here:

http://sourceforge.net/p/cbflib/code-0/HEAD/tree/trunk/CBFlib/src/cbf_hdf5.c

Some documentation is here:

http://cbflib.sourceforge.net/doc/CBFlib.html#2.7

The short bit we already have in the manual is here: http://download.nexusformat.org/sphinx/design.html#coordinate-transformations

@zjttoefs

This comment has been minimized.

Contributor

zjttoefs commented Oct 6, 2015

This poster is probably the most useful to visually experience the CBF-NeXus mapping:

https://sites.google.com/site/nexuscbf/home/presentation-foils/Integration_Poster_10May14_w_overlays.pdf

@zjttoefs zjttoefs removed their assignment May 13, 2016

@prjemian prjemian referenced this issue Dec 6, 2016

Merged

(issue 492) NXcanSAS v1.0 release #516

5 of 5 tasks complete

prjemian added a commit that referenced this issue Jun 21, 2017

Merge pull request #554 from nexusformat/geometry_docs_397
Geometry docs update, leaving #397 open since I believe there is more work to be done to clarify the NeXus geometry description

@prjemian prjemian modified the milestone: NXDL 3.4 Jun 30, 2017

@zjttoefs

This comment has been minimized.

Contributor

zjttoefs commented Aug 14, 2017

I don't think there is a concrete problem outstanding. There is always room for improvement.

@zjttoefs zjttoefs closed this Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment