Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXsas: review minOccurs and group names #1194

Merged
merged 17 commits into from
Sep 16, 2022
Merged

NXsas: review minOccurs and group names #1194

merged 17 commits into from
Sep 16, 2022

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Sep 15, 2022 •
edited
Loading

@prjemian prjemian added this to the NXDL 2023.06 milestone Sep 15, 2022
@prjemian prjemian requested a review from a team September 15, 2022 16:59
@prjemian prjemian self-assigned this Sep 15, 2022
prjemian
prjemian commented Sep 16, 2022
View reviewed changes
applications/NXsas.nxdl.xml Outdated Show resolved Hide resolved
prjemian
prjemian commented Sep 16, 2022
View reviewed changes
applications/NXsas.nxdl.xml Outdated Show resolved Hide resolved
prjemian
prjemian commented Sep 16, 2022
View reviewed changes
applications/NXsas.nxdl.xml Outdated Show resolved Hide resolved
prjemian
prjemian commented Sep 16, 2022
View reviewed changes
applications/NXsas.nxdl.xml Outdated Show resolved Hide resolved
prjemian
prjemian commented Sep 16, 2022
View reviewed changes
applications/NXsas.nxdl.xml Outdated Show resolved Hide resolved
prjemian
prjemian commented Sep 16, 2022
View reviewed changes
applications/NXsas.nxdl.xml Outdated Show resolved Hide resolved
prjemian
prjemian commented Sep 16, 2022
View reviewed changes
applications/NXsas.nxdl.xml Outdated Show resolved Hide resolved
prjemian
prjemian commented Sep 16, 2022
View reviewed changes
applications/NXsas.nxdl.xml Outdated Show resolved Hide resolved
benajamin
benajamin approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@benajamin benajamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PeterC-DLS
PeterC-DLS approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@PeterC-DLS PeterC-DLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We defer any consideration of dimension ordering in the data field to another issue

@benajamin benajamin mentioned this pull request Sep 16, 2022
Closed
@prjemian
Copy link
Contributor Author

@PeterC-DLS @benajamin Thanks for the review!

@prjemian prjemian merged commit 45729f3 into main Sep 16, 2022
@prjemian prjemian deleted the 522-NXsas-review branch September 16, 2022 15:39
@PeterC-DLS PeterC-DLS modified the milestones: NXDL 2023.06, NXDL 2023.10 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

@benajamin benajamin benajamin approved these changes

Assignees

@prjemian prjemian

Labels
definitions
Projects
No open projects
NIAC2022 project
Status: Done
Milestone
NXDL 2023.10
Development

Successfully merging this pull request may close these issues.

NXsas: review use of minOccurs on various components NXsas: review use of minOccurs on various components
3 participants
@prjemian @PeterC-DLS @benajamin