Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StealthLike Develop #1

Merged
merged 59 commits into from Oct 16, 2013

Conversation

Projects
None yet
7 participants
@nezumi650
Copy link
Owner

commented Aug 25, 2013

StealthLike Develop

For test: nezumi650/testForStealthLike#3

@2get

This comment has been minimized.

@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Aug 27, 2013

Stealth Liked:

metadata を記載しましょう

1 similar comment
@shikakun

This comment has been minimized.

Copy link
Collaborator

commented Aug 27, 2013

Stealth Liked:

metadata を記載しましょう




$(function() {

This comment has been minimized.

Copy link
@2get

2get Aug 27, 2013

$ は jQuery と思いますが @require で jQuery ロードしないと使えないと思います。(もしjQueryが本当に必要で使うなら)

This comment has been minimized.

Copy link
@nezumi650

nezumi650 Oct 5, 2013

Author Owner

fixed.

postLikeComment(window.getSelection());
return false;
});
});

This comment has been minimized.

Copy link
@2get

2get Aug 27, 2013

全体を即時関数内に書きましょう。
グローバルに書くのはよろしくありません。

(function() {

})();

This comment has been minimized.

Copy link
@h13i32maru

h13i32maru Oct 3, 2013

FirefoxのGreasemoneky、ChromeのUserScriptでは即時関数で囲まなくても変数がグローバルに漏れることはなかったと思います。
(GMは実行時に即時関数でくるんでくれる、Chromeはそもそも別のコンテキストで実行される)

ただ、それ以外の環境はどうなのかわからないですし、即時関数でくるむと処理を途中で中断できるので慣例としてくるんでおいたほうがよいと僕も思います。

This comment has been minimized.

Copy link
@nezumi650

nezumi650 Oct 5, 2013

Author Owner

fixed.

+ "right: 20px;";

var footerElm = document.querySelector('div .site-footer');
footerElm.appendChild(buttonElement);

This comment has been minimized.

Copy link
@2get

2get Aug 27, 2013

buttonElementfooterElm がありますが変数の命名が不規則です。

This comment has been minimized.

Copy link
@nezumi650

nezumi650 Oct 5, 2013

Author Owner

fixed.

@@ -0,0 +1,52 @@
//"use strict";

This comment has been minimized.

Copy link
@2get

2get Aug 27, 2013

スクリプト全体でシングルクォーテーションとダブルクォーテーションが混在しているのでどちらかに統一しましょう。
シングルクォーテーション使えるならシングルクォーテーションに統一するのが好きです。

This comment has been minimized.

Copy link
@nezumi650

nezumi650 Oct 5, 2013

Author Owner

fixed.

$(window).scroll(function () {
var currentUrl = location.href;
result1 = currentUrl.match(/github\.com.*pull/);
result2 = currentUrl.match(/commits$/);

This comment has been minimized.

Copy link
@2get

2get Aug 27, 2013

result1result2 という名前でこの変数に何が入っているのかわかりません。
もし、true, false などの boolean 値が入っているなら、isHoge、hasHoge のような名前にするとよいと思います。

This comment has been minimized.

Copy link
@nezumi650

nezumi650 Oct 5, 2013

Author Owner

fixed.

@2get

This comment has been minimized.

Copy link

commented Aug 27, 2013

全体を即時関数で!

$(window).scroll(function () {
var currentUrl = location.href;
var isGithub = currentUrl.match(/github\.com.*pull/);
var isCommitsPage = currentUrl.match(/commits$/);

This comment has been minimized.

Copy link
@2get

2get Aug 27, 2013

ページで実行するしないは、metadata でかけます!

This comment has been minimized.

Copy link
@nezumi650

nezumi650 Sep 3, 2013

Author Owner

metadata にこんな風に書いてみたのですが、うまく動作制御する事ができなかったので、
とりあえず残してあります。

// @exclude             https://github.com/*/pull/*/commits
// @include             https://github.com/*/pull/*/files
// @include             https://github.com/*/pull/*

This comment has been minimized.

Copy link
@nezumi650

nezumi650 Oct 5, 2013

Author Owner

fixed.

@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Sep 3, 2013

#issuecomment-23313388

metadata を記載しましょう。

記載しました

@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Sep 3, 2013

#issuecomment-23337853

全体を即時関数で!

対応しました。

@@ -0,0 +1,110 @@
//'use strict';

This comment has been minimized.

Copy link
@2get

2get Sep 3, 2013

'use strict'; コメントしちゃ意味がないですよ。書くなら (function() { の下に書きましょう。

This comment has been minimized.

Copy link
@nezumi650

nezumi650 Oct 5, 2013

Author Owner

fixed.

nezumi650 added some commits Oct 6, 2013

Merge pull request #6 from iizukak/suggest-strict-equal-operator
等値演算子を同値演算子に書き換え
リファクタリング
ネストが深すぎたので浅くした
中間セーブ
いいねしたら即時ハイライト&ミニアバターを表示したいが、まだなんかちょっとうまくいってない
@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Oct 9, 2013

即時ハイライト実装したいんだけどうまくいかないなー。
第二フェーズって事で、とりあえずは諦めかなぁ。

@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Oct 15, 2013

#discussion-diff-6714757
このコメントの内容については、全く理解できていないので、別途勉強します。

@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Oct 16, 2013

Nice! 👍

+'use strict';
@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Oct 16, 2013

Stealth Liked 👍

StealthLike Develop

@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Oct 16, 2013

マージします!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

nezumi650 added a commit that referenced this pull request Oct 16, 2013

@nezumi650 nezumi650 merged commit b1898bf into master Oct 16, 2013

@nezumi650 nezumi650 deleted the first-dev branch Oct 16, 2013

@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Oct 16, 2013

@2get @shikakun @h13i32maru @iizukak

皆さんのおかげで、ついにリリースできました。
本当にありがとうございました。

(拡散は、明日します。

@lamanotrama

This comment has been minimized.

Copy link

commented Oct 17, 2013

Stealth Liked 👍

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

1 similar comment
@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Oct 17, 2013

Stealth Liked 👍

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@nezumi650

This comment has been minimized.

Copy link
Owner Author

commented Dec 6, 2013

Nice! 👍

+                    discussionBubble.style.display = 'none';
+                    discussionBubble.parentNode.removeChild(discussionBubble);
@nakajijapan

This comment has been minimized.

Copy link

commented Feb 3, 2014

Stealth Liked 👍

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.