Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QIIME2 2018.6 to 2019.7 #97

Merged
merged 15 commits into from Dec 5, 2019
Merged

Update QIIME2 2018.6 to 2019.7 #97

merged 15 commits into from Dec 5, 2019

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Aug 10, 2019

Running with -profile test,conda & -profile test_multi,conda works.

Still to test/confirm that

  • results are similar to v1.1.0 output Actually similar but not identical, because DADA2 v1.06 to v1.10.
  • -profile test ignores an error at alpha_diversity (observed_otus_vector), which shouldn't fail
  • automatic generation of the classification database works

@d4straub d4straub added the enhancement New feature or request label Aug 10, 2019
@d4straub d4straub added this to the v1.1.1 milestone Aug 10, 2019
@d4straub d4straub self-assigned this Aug 10, 2019
@d4straub
Copy link
Collaborator Author

d4straub commented Aug 16, 2019

Once it is merged and the new container is build it should work.

edit: this should fix #78 and make #41 possible to solve.

edit2: after more testing in dev it could be released as 1.1.1

@d4straub
Copy link
Collaborator Author

d4straub commented Sep 5, 2019

About linting test failures:
All qiime2 stuff comes from Channel qiime2/label/r2019.7, would it maybe help to add that specifically? edit: nope, it doesn't!

Conda dependency had an unknown version:
libgcc-ng=9.1.0
libgfortran-ng=7.3.0
libstdcxx-ng=9.1.0
xopen=0.7.3
edit: nope, version is correct.

Despite the linting problems, the environment works with conda.

@apeltzer apeltzer changed the base branch from dev to 2019-7 December 5, 2019 08:22
@apeltzer
Copy link
Member

apeltzer commented Dec 5, 2019

Merging this to 2019-07, to see if things work and also update accordingly where necessary.

@apeltzer apeltzer merged commit d3221ab into nf-core:2019-7 Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants