Migrate ssuissero to topic channel versions and add stub block#11403
Merged
Conversation
- Converted versions.yml output to topic channel (versions_ssuissero) Uses hardcoded version (1.0.1) as tool does not provide CLI versioning - Removed END_VERSIONS heredoc from script block - Added stub block with touch for .tsv output - Updated existing test to use sanitizeOutput(process.out) - Added stub test case - Restored EDAM ontology comment (# TSV) Contributes to nf-core#4570
SPPearce
requested changes
Apr 30, 2026
Contributor
SPPearce
left a comment
SPPearce
left a comment
There was a problem hiding this comment.
When the version number is fixed, it should be emitted using val instead of eval(echo )
| tuple val(meta), path("*.tsv"), emit: tsv | ||
| path "versions.yml" , emit: versions | ||
| // WARN: Version information not provided by tool on CLI. Please update version string below when bumping container versions. | ||
| tuple val("${task.process}"), val('ssuissero'), eval('echo 1.0.1'), emit: versions_ssuissero, topic: versions |
Contributor
There was a problem hiding this comment.
Suggested change
| tuple val("${task.process}"), val('ssuissero'), eval('echo 1.0.1'), emit: versions_ssuissero, topic: versions | |
| tuple val("${task.process}"), val('ssuissero'), val('1.0.1'), emit: versions_ssuissero, topic: versions |
| - ssuissero: | ||
| type: string | ||
| description: The name of the tool | ||
| - echo 1.0.1: |
Contributor
There was a problem hiding this comment.
Suggested change
| - echo 1.0.1: | |
| - 1.0.1: |
| - ssuissero: | ||
| type: string | ||
| description: The name of the tool | ||
| - echo 1.0.1: |
Contributor
There was a problem hiding this comment.
Suggested change
| - echo 1.0.1: | |
| - 1.0.1: |
Applies reviewer code suggestions:
- eval('echo 1.0.1') → val('1.0.1')
- Updated meta.yml version entries from eval to val type
Contributor
Author
|
@SPPearce — all three suggestions applied:
CI green across all github actions for this PR. |
SPPearce
approved these changes
May 17, 2026
manascripts
pushed a commit
to manascripts/modules
that referenced
this pull request
May 21, 2026
…re#11403) * Migrate ssuissero to topic channel versions and add stub block - Converted versions.yml output to topic channel (versions_ssuissero) Uses hardcoded version (1.0.1) as tool does not provide CLI versioning - Removed END_VERSIONS heredoc from script block - Added stub block with touch for .tsv output - Updated existing test to use sanitizeOutput(process.out) - Added stub test case - Restored EDAM ontology comment (# TSV) Contributes to nf-core#4570 * fix(ssuissero): use val() for hardcoded version per reviewer Applies reviewer code suggestions: - eval('echo 1.0.1') → val('1.0.1') - Updated meta.yml version entries from eval to val type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the
ssuisseromodule to the new stub+topic channel architecture.Changes
versions.ymloutput to topic channel (versions_ssuissero) using hardcoded version (1.0.1) since the tool lacks a CLI version flagEND_VERSIONSheredoc from script blockstub:blocksanitizeOutput(process.out)and added stub test caseversionsoutput block frommeta.ymlContributes to #4570