Skip to content

Add new component: cnvkit/coverage#11714

Merged
aadecock merged 5 commits into
masterfrom
cnvkit/coverage
May 20, 2026
Merged

Add new component: cnvkit/coverage#11714
aadecock merged 5 commits into
masterfrom
cnvkit/coverage

Conversation

@aadecock
Copy link
Copy Markdown
Contributor

PR checklist

Add coverage functionality to cnvkit
Closes #11193

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@aadecock aadecock self-assigned this May 20, 2026
@mashehu
Copy link
Copy Markdown
Contributor

mashehu commented May 20, 2026

@nf-core-bot fix linting

Copy link
Copy Markdown
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small non-breaking comments, feel free to merge once they've been fixed

Comment thread modules/nf-core/cnvkit/coverage/main.nf Outdated
Comment thread modules/nf-core/cnvkit/coverage/main.nf Outdated
// interval file can be target or antitarget bed file.

output:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment thread modules/nf-core/cnvkit/coverage/main.nf Outdated
Comment on lines +14 to +16
// alignement file can be BAM or CRAM
// in cnvkit version 0.9.13, a bedGraph (.bed.gz) file is also accepted. extract per-base coverage from BAM files once (eg. with bedtools genomecov -gb)
// interval file can be target or antitarget bed file.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the description in the meta.yml file :)

aadecock and others added 2 commits May 20, 2026 15:17
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
@aadecock aadecock added this pull request to the merge queue May 20, 2026
Merged via the queue into master with commit a7e6876 May 20, 2026
23 checks passed
@aadecock aadecock deleted the cnvkit/coverage branch May 20, 2026 13:44
manascripts pushed a commit to manascripts/modules that referenced this pull request May 21, 2026
* Add new component: cnvkit/coverage

* fix: update cnvkit version to 0.9.13 and add quay.io prefix

* [automated] Fix code linting

* Apply suggestion from @nvnieuwk

Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>

* fixed comments from reviewer - remove blank lines and move comments to meta.yml

---------

Co-authored-by: aaron-de-cock <aaron.de.cock@student.howest.be>
Co-authored-by: nf-core-bot <core@nf-co.re>
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: CNVKIT/COVERAGE

5 participants