Skip to content

Migrate snpsift/split to topic channel versions#11732

Merged
jonasscheid merged 4 commits into
nf-core:masterfrom
jonasscheid:snpsift-split-topic-channels
May 21, 2026
Merged

Migrate snpsift/split to topic channel versions#11732
jonasscheid merged 4 commits into
nf-core:masterfrom
jonasscheid:snpsift-split-topic-channels

Conversation

@jonasscheid
Copy link
Copy Markdown
Contributor

No description provided.

jonasscheid and others added 3 commits May 21, 2026 10:43
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ta.split key

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@jonasscheid jonasscheid marked this pull request as ready for review May 21, 2026 11:21
Comment thread modules/nf-core/snpsift/split/main.nf Outdated
output:
tuple val(meta), path("*.vcf"), emit: out_vcfs
path "versions.yml", emit: versions
tuple val("${task.process}"), val('snpsift'), eval("SnpSift split -h 2>&1 | head -n1 | sed 's/^.*version //; s/ .*//'"), topic: versions, emit: versions_snpsift
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tuple val("${task.process}"), val('snpsift'), eval("SnpSift split -h 2>&1 | head -n1 | sed 's/^.*version //; s/ .*//'"), topic: versions, emit: versions_snpsift
tuple val("${task.process}"), val('snpsift'), eval("SnpSift split -h 2>&1 | sed -n 's/.*version \([^ ]*\).*/\1/p;q'"), topic: versions, emit: versions_snpsift

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@jonasscheid jonasscheid added this pull request to the merge queue May 21, 2026
Merged via the queue into nf-core:master with commit 9091c30 May 21, 2026
29 checks passed
@jonasscheid jonasscheid deleted the snpsift-split-topic-channels branch May 21, 2026 11:53
manascripts pushed a commit to manascripts/modules that referenced this pull request May 21, 2026
* Migrate snpsift/split to topic channel versions

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Drive snpsift/split join mode via ext.args instead of non-standard meta.split key

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Use args.tokenize() for exact -j flag matching in snpsift/split

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Apply review suggestion: simplify snpsift version eval to a single sed

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants