Skip to content

DeepBGC: tiny revisiosn#2070

Merged
louperelo merged 4 commits into
nf-core:masterfrom
jasmezz:deepbgc_review
Sep 15, 2022
Merged

DeepBGC: tiny revisiosn#2070
louperelo merged 4 commits into
nf-core:masterfrom
jasmezz:deepbgc_review

Conversation

@jasmezz
Copy link
Copy Markdown
Contributor

@jasmezz jasmezz commented Sep 15, 2022

Since I missed my chance to review both DeepBGC modules before merge, here are some tiny suggestions.
The tag in main.nf is not needed.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@jasmezz jasmezz requested a review from louperelo September 15, 2022 14:26
@louperelo louperelo merged commit e55012f into nf-core:master Sep 15, 2022
matthdsm pushed a commit to matthdsm/nf-core-modules that referenced this pull request Sep 28, 2022
* Fix variable prodigal_tf

* Remove tag in main.nf + tiny suggestions in ymls

Co-authored-by: louperelo <44900284+louperelo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants