Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated test data paths batch 8 #6065

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Jul 31, 2024

PR checklist

Closes #XXX

  • Updated test data paths batch 8
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@GallVp
Copy link
Member Author

GallVp commented Jul 31, 2024

@SPPearce
Copy link
Contributor

A conda package seems to be broken?

https://github.com/nf-core/modules/actions/runs/10172683953/job/28139842853#step:14:175

Strange, it is listed in the recipe.
It was passing the tests previously, it is a very tricky package to actually use. One option is to make an issue for any failures and leave them out for the moment.

I've just tried explicitly adding the package to the environment.yml, but I'm not able to run the current version in conda on gitpod either.

@GallVp
Copy link
Member Author

GallVp commented Aug 1, 2024

For now, going to leave fastqscreen out. Issue raised: #6075

@GallVp
Copy link
Member Author

GallVp commented Aug 1, 2024

Excluded bowtie2/build to avoid nf-test trigger for fastqscreen_fastqscreen

@SPPearce SPPearce added this pull request to the merge queue Aug 1, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@SPPearce SPPearce added this pull request to the merge queue Aug 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 1, 2024
@SPPearce SPPearce added this pull request to the merge queue Aug 1, 2024
Merged via the queue into nf-core:master with commit 9bfc818 Aug 1, 2024
50 checks passed
@GallVp GallVp deleted the testpaths/batch8 branch August 1, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants