Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastQC fails when fastq file is not in gzip format #43

Closed
lwratten opened this issue Dec 3, 2019 · 3 comments
Closed

FastQC fails when fastq file is not in gzip format #43

lwratten opened this issue Dec 3, 2019 · 3 comments
Labels
question Further information is requested

Comments

@lwratten
Copy link
Contributor

lwratten commented Dec 3, 2019

I found this when I tried to run with the --skip_basecalling flag on some data we have
This is due to the symbolic link we create at the start
image
Are we making it mandatory for the fastq to be gzipped, or will we add a case here so it doesn't break?

@lwratten lwratten added the question Further information is requested label Dec 3, 2019
@drpatelh
Copy link
Member

drpatelh commented Dec 5, 2019

This should fail more elegantly in the CheckSampleSheet process right?

if fastq[-9:] != '.fastq.gz' and fastq[-6:] != '.fq.gz':

Shouldnt be able to get to the FastQC process unless there is a bug somewhere. What does you sample sheet look like @lwratten ?

Yes, I think we should insist on the fastq files being zipped. Much more storage friendly.

@drpatelh
Copy link
Member

drpatelh commented Dec 6, 2019

Ok. I found the bug. Basically we arent exiting if the if statement above fails. Ill fix in the next PR.

@drpatelh
Copy link
Member

Fixed in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants