From 708b4273c8500e0d4b937da4e21da7eeec86f895 Mon Sep 17 00:00:00 2001 From: maxulysse Date: Mon, 26 May 2025 18:34:00 +0200 Subject: [PATCH 1/3] update RFC curator workflow docs --- README.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/README.md b/README.md index 291d321..66cc96e 100644 --- a/README.md +++ b/README.md @@ -44,3 +44,16 @@ The curator workflow is as follows: - [ ] If a proposal is accepted, update both the label AND status to 'accepted', and when closing select 'Close as completed' - [ ] If a proposal is turned down, update both the label AND status to 'turned-down', and when closing select 'Close as not planned' - [ ] If a proposal is not completed or abandoned after a year, update both the label AND status to 'timed-out', and when closing select 'Close as not planned' + +### Request for Comment (RFC) + +The curator workflow is as follows: + +- [ ] Once a issue is made, update the 'Project' status to 'proposed' (right hand side bar, under 'new--proposals') +- [ ] Facilitate discussion on the the Issue thread, following the guidance [here](https://nf-co.re/docs/contributing/project_proposals). +- [ ] Acceptance requires a minimum of OKs from: + - Two members of the core team. + - One member of the core team and one member of the maintainers team. +- [ ] If a proposal is accepted, update both the label AND status to 'accepted', and when closing select 'Close as completed' +- [ ] If a proposal is turned down, update both the label AND status to 'turned-down', and when closing select 'Close as not planned' +- [ ] If a proposal is not completed or abandoned after a year, update both the label AND status to 'timed-out', and when closing select 'Close as not planned' From 1ea07268b2613ff9ce170bdb54f09f7bbb0ba26b Mon Sep 17 00:00:00 2001 From: Maxime U Garcia Date: Tue, 27 May 2025 09:53:58 +0200 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Phil Ewels --- README.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 66cc96e..7ba1ea7 100644 --- a/README.md +++ b/README.md @@ -51,9 +51,7 @@ The curator workflow is as follows: - [ ] Once a issue is made, update the 'Project' status to 'proposed' (right hand side bar, under 'new--proposals') - [ ] Facilitate discussion on the the Issue thread, following the guidance [here](https://nf-co.re/docs/contributing/project_proposals). -- [ ] Acceptance requires a minimum of OKs from: - - Two members of the core team. - - One member of the core team and one member of the maintainers team. -- [ ] If a proposal is accepted, update both the label AND status to 'accepted', and when closing select 'Close as completed' -- [ ] If a proposal is turned down, update both the label AND status to 'turned-down', and when closing select 'Close as not planned' +- [ ] Acceptance requires quorum from the nf-core core team, done via voting in comments with `/accept` or `/reject` +- [ ] If a proposal is accepted, update both the issue label AND project status to 'accepted', and when closing select 'Close as completed' +- [ ] If a proposal is turned down, update both the issue label AND project status to 'turned-down', and when closing select 'Close as not planned' - [ ] If a proposal is not completed or abandoned after a year, update both the label AND status to 'timed-out', and when closing select 'Close as not planned' From 58bf41ed466df09f697a9e306d4631d126f40c6e Mon Sep 17 00:00:00 2001 From: maxulysse Date: Tue, 27 May 2025 18:50:51 +0200 Subject: [PATCH 3/3] More details --- README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 7ba1ea7..efba5bb 100644 --- a/README.md +++ b/README.md @@ -52,6 +52,9 @@ The curator workflow is as follows: - [ ] Once a issue is made, update the 'Project' status to 'proposed' (right hand side bar, under 'new--proposals') - [ ] Facilitate discussion on the the Issue thread, following the guidance [here](https://nf-co.re/docs/contributing/project_proposals). - [ ] Acceptance requires quorum from the nf-core core team, done via voting in comments with `/accept` or `/reject` -- [ ] If a proposal is accepted, update both the issue label AND project status to 'accepted', and when closing select 'Close as completed' -- [ ] If a proposal is turned down, update both the issue label AND project status to 'turned-down', and when closing select 'Close as not planned' -- [ ] If a proposal is not completed or abandoned after a year, update both the label AND status to 'timed-out', and when closing select 'Close as not planned' +- [ ] If a proposal is turned down, update both the label AND status to 'turned-down', and when closing select 'Close as not planned' +- [ ] If a proposal is accepted, update both the label AND status to 'accepted', and ask the champion to write a formal RFC and begin initial development. +- [ ] When the PR is opened the corresponding issue can be closed. +- [ ] Verify that feedback has been provided to the champion. +- [ ] Propose an optional Bytesize talk about the proposal. +- [ ] Finally merge the PR when the development is complete.