Skip to content

Remove 2 year old nf-core/interproscan module#54

Merged
olgabot merged 2 commits into
devfrom
olgabot/remove-old-nf-core-interproscan
Jun 25, 2025
Merged

Remove 2 year old nf-core/interproscan module#54
olgabot merged 2 commits into
devfrom
olgabot/remove-old-nf-core-interproscan

Conversation

@olgabot

@olgabot olgabot commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

The current nf-core/interproscan module uses InterProScan v5.59_91.0 https://github.com/nf-core/modules/blob/7e6203130b8df70c3b4f3e040c8c8caacd170b55/modules/nf-core/interproscan/main.nf#L9C10-L9C57 (interproscan-5.59-91.0 release). We're currently using 5.74-105.0

We have an active recipe to update InterProScan versions on bioconda-recipes (bioconda/bioconda-recipes#54898) to 5.73-104.0 (released Apr 24, 2025), but that hasn't finished yet.

PR checklist

  • This comment contains a description of changes (with reason).
  • NA - If you've fixed a bug or added code that should be tested, add tests!
  • NA - If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • NA - If necessary, also make a PR on the nf-core/proteinannotator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (e.g. nf-test test */local --profile=~test,docker for all new local tests).
  • NA - Check for unexpected warnings in debug mode (nf-test test */local --profile=~test,docker,debug).
  • NA - Usage Documentation in docs/usage.md is updated.
  • NA - Output Documentation in docs/output.md is updated.
  • NA - CHANGELOG.md is updated.
  • NA - README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7e39138

+| ✅ 199 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-proteinannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-proteinannotator_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-proteinannotator_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.1
  • Run at 2025-06-25 17:01:40

@vagkaratzas vagkaratzas self-requested a review June 25, 2025 16:58
@olgabot olgabot merged commit 3f47a32 into dev Jun 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vagkaratzas vagkaratzas vagkaratzas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olgabot @vagkaratzas